Set sizer overflow to hidden. #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to be acquired via the scrollWidth property, but it also compensates for a weird bug in FireFox.
|
I've also had to play a bit with |
|
@JedWatson any update on this? Would like to have this in so we don't need to patch it. |
|
This raises the input above the line on Firefox 60.0.2 on OSX El Capitain. I wouldn't support this fix without further explanation. Sandbox: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been experiencing some odd bugs in different versions of FireFox where the width is being calculate incorrectly when I apply horizontal padding on the underlying input. Although I have seen this issue occur multiple times, it has been very hard to reproduce within my own system, so I am not going to try to reproduce in a generic example.
I have found that setting overflow to hidden fixes the problem, but still allows the sizer width to be determined via the scrollWidth property. I have provided a Codepen below that demonstrates this behavior.
https://codepen.io/anon/pen/jaeWpN