Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: new @types/react support #394

Merged
merged 3 commits into from
Apr 21, 2024
Merged

fix: new @types/react support #394

merged 3 commits into from
Apr 21, 2024

Conversation

Netail
Copy link

@Netail Netail commented Apr 20, 2024 •
edited
Loading

target v2 branch; #392

jonkoops
jonkoops requested changes Apr 20, 2024
View reviewed changes
Copy link
Collaborator

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add some test cases with bigint to the type tests and unit tests?

@Netail Netail requested a review from jonkoops April 20, 2024 15:48
jonkoops
jonkoops requested changes Apr 20, 2024
View reviewed changes
Copy link
Collaborator

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's get rid of the unrelated formatting changes.

jonkoops
jonkoops approved these changes Apr 21, 2024
View reviewed changes
Copy link
Collaborator

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks @Netail!

@jonkoops jonkoops merged commit 5aaf463 into JedWatson:v2 Apr 21, 2024
5 checks passed
@Netail Netail deleted the fix/react-types branch April 21, 2024 21:00
@jonkoops
Copy link
Collaborator

Just FYI, v2 releases are currently blocked on #393. I might switch v2 back to main and main to v3, so we can perhaps push out a release. @dcousens WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonkoops jonkoops jonkoops approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Netail @jonkoops