-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set value for effective cache size and use PR #41 for ome.postgresql #424
base: master
Are you sure you want to change the base?
Conversation
I think the tests have failed because of the requests version 2.32.0 bug. I have modified the workflow to install "requests < 2.32.0" |
Deployed as
|
I have updated the Postgres Ansible role (ome/ansible-role-postgresql#41 (comment)), so it will account for this situation and the added variables will not be duplicated by the end of the configuration file. |
Proposing to deploy this as part of |
Note this has been deployed on Below is the diff between the PostgreSQL configuration on sbesson@Sebastiens-MacBook-Pro-3 Downloads % diff postgresql.conf.prod122 postgresql.conf.test122
0a1
> #Ansible managed
822a824
>
825,827c827,828
< shared_buffers = 8002MB
<
< max_connections = 150
---
> effective_cache_size = 23880MB
> shared_buffers = 7960MB |
The effective_cache_size value on
We have changed this value manullay on I could not find the container which was used to index the data on the So, to have the required comparison, I have run the indexer on the I have set the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the report. Assuming there are no other performance measurements expected by the IDR, I think the next steps would be for to review, merge & release the upstream role and update this PR.
As a possible follow-up, the IDR PostgreSQL configuration file could be cleaned up for better readability / maintenance by commenting the configuration lines which are identical to the default or overridden at the bottom of the file like shared_buffers
and effective_cache_size
.
FYI I have cherry-picked 77b1653 and pushed it to the HEAD of origin/master. While we are waiting for this work to be completed, this should prevent regressions when running the deployment playbooks against production environment and ensure the PSQL database has a properly set |
This PR sets a value for the effective_cache_size attribute (75% of the physical machine memory ) and uses ome/ansible-role-postgresql#41