Include first error message in GitHub annotation #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
reviewed
Sep 16, 2024
carlocab
force-pushed
the
include-error-annotation
branch
from
ff09d8f
to
db70c6d
Compare
The first error message is often found before the last 256 lines, so isn't included in the annotation. Let's adjust `#truncate_output` so it includes this error message if found instead. Searching for error messages is a little naive, but it matches the way `clang`, `gcc`, and `rustc` print error messages. We can make this more sophisticated later if desired.
carlocab
force-pushed
the
include-error-annotation
branch
from
db70c6d
to
40e110a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first error message is often found before the last 256 lines, so
isn't included in the annotation.
Let's adjust
#truncate_outputso it includes this error message iffound instead. Searching for error messages is a little naive, but it
matches the way
clang,gcc, andrustcprint error messages. We canmake this more sophisticated later if desired.