Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water wise cloudmeta update #69

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

maddendeavor
Copy link

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • [X ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Updated if-plugin to include WUE data for different Azure datacenters and the AWS fleet wide values
  • All corrected erroneous data for Azure data center locations

Yes!

@jmcook1186
Copy link
Contributor

Hi @maddendeavor this looks great, but could you keep it in your own Github repository rather than merging it into ours? The aim is to have lots of plugins maintained by the community so we are not bottlenecked by the IF team's ability to maintain them all - we will soon have a public website where plugins can be listed and linked.

@adrianco
Copy link

Hi Christine, I run the real-time-cloud GSF project that is the original source for the gif-data.csv - I'd like to discuss whether and how to merge your WUE data into our updated cloud region metadata info that we are exporting into an updated IF for cloud.

@maddendeavor
Copy link
Author

maddendeavor commented Apr 25, 2024 via email

@maddendeavor
Copy link
Author

@adrianco I know it has been a while, but just following up on your message again to see if you still wanted to discuss the merge. Thanks!

@adrianco
Copy link

adrianco commented Jul 2, 2024

Sorry I didn't see this, however I did include the WUE data in the proposed real-time-cloud region metadata info. Here's my current fork: https://github.com/adrianco/real-time-cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants