Consider null value in carbonIntensity on EM #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue Green-Software-Foundation#571 Signed-off-by: Yasumasa Suenaga <[email protected]>
22 tasks
vaughanknight
approved these changes
Oct 15, 2024
18 tasks
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue Number: #571
Summary
Consider null value(s) if it is returned from Electricity Maps.
This PR set
-1toHistoryCarbonIntensityData.VaulewhencarbonIntensityin response body from Electricity Maps isnull. But I'm not sure it is ok because-1does not meannull- it might be ok it is documented. Or we can exclude it in filter phase in data source implementation. What do you think?Changes
Checklist
Are there API Changes?
No
Is this a breaking change?
No
This PR Closes #571