Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in packaging doc #374

Merged
merged 5 commits into from
Jul 27, 2023

Conversation

romanlutz
Copy link
Contributor

Pull Request

Issue Number: -

Summary

Fixing typos in the packaging doc

Changes

  • just typo fixes

Checklist

  • Local Tests Passing?
  • CICD and Pipeline Tests Passing?
  • Added any new Tests?
  • Documentation Updates Made?
  • Are there any API Changes? If yes, please describe below.
  • This is not a breaking change. If it is, please describe it below.

Are there API Changes?

If yes, what are the expected API Changes? Please link to an API-Comparison
workflow with the API Diff.

Is this a breaking change?

If yes, what workflow does this break?

Anything else?

Other comments, collaborators, etc.

Please follow
GitHub's suggested syntax
to link Pull Requests to Issues via keywords

@danuw
Copy link
Collaborator

danuw commented Jul 25, 2023

Hi @romanlutz - thank you for your inputs. Can you please add the DCO (sign your commits - click on details in the workflow list above or below)?

@Willmish
Copy link
Collaborator

Hi @romanlutz and thanks for your contribution! To get this right, you also need to signoff your commit, normally you do it on each commit using git commit -s , you can also add a new remediation commit manually:

DCO Remediation Commit for Roman Lutz <[email protected]>

I, Roman Lutz <[email protected]>, hereby add my Signed-off-by to this commit: 9cec88351fe46fe0291eeba9fecd53089ce17240

Signed-off-by: Roman Lutz <[email protected]>

Or since there is only 1 commit here, I suggest you do a single commit rebase on your fix branch romanlutz/fix_typos: rebase -i 9cec88351fe46fe0291eeba9fecd53089ce17240)~ and change the command for the most recent commit from pick to edit, then simply do git commit --amend -s which will add the signoff. You can then force push to your branch and replace this commit (9cec883) with a signed off one.

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2023

Codecov Report

Merging #374 (ab4cdcc) into dev (ad44005) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #374   +/-   ##
=======================================
  Coverage   74.21%   74.21%           
=======================================
  Files          77       77           
  Lines        2637     2637           
  Branches      266      266           
=======================================
  Hits         1957     1957           
  Misses        598      598           
  Partials       82       82           

YaSuenag and others added 4 commits July 27, 2023 15:47
Signed-off-by: Yasumasa Suenaga <[email protected]>
* cleaning workflows

Signed-off-by: Dan Benitah <[email protected]>

* pull request should on trigger for pull request event - removing on push for PRs

Signed-off-by: Dan Benitah <[email protected]>

* syntax

Signed-off-by: Dan Benitah <[email protected]>

* syntax

Signed-off-by: Dan Benitah <[email protected]>

* moving markdown linting and disabling 2.a-deploy

Signed-off-by: Dan Benitah <[email protected]>

* adding some jobs dependencies so packaging does not run if code does not build etc...

Signed-off-by: Dan Benitah <[email protected]>

* moving code analysis into the build step and clean up

Signed-off-by: Dan Benitah <[email protected]>

---------

Signed-off-by: Dan Benitah <[email protected]>
Co-authored-by: danuw <[email protected]>
* Skip deploy workflows in forked repos

Signed-off-by: Yasumasa Suenaga <[email protected]>

* Add vars

Signed-off-by: Yasumasa Suenaga <[email protected]>

---------

Signed-off-by: Yasumasa Suenaga <[email protected]>
Signed-off-by: Roman Lutz <[email protected]>
@romanlutz
Copy link
Contributor Author

I think I did it right now @danuw @Willmish but let me know if there's anything else!

@danuw
Copy link
Collaborator

danuw commented Jul 27, 2023

LGTM
Thank you for those changes. Waiting for the workflows to complete successfully.

@Willmish
Copy link
Collaborator

Hey @danuw , if you will be merging this now, can you squash it? There seem to be some rebasing commits in the history (and double check the history please)

@danuw danuw merged commit ede7ab7 into Green-Software-Foundation:dev Jul 27, 2023
8 checks passed
@danuw
Copy link
Collaborator

danuw commented Jul 27, 2023

LGTM
Thank you for those changes. Waiting for the workflows to complete successfully.

EDIT: all green. Thank you for your contribution

@romanlutz romanlutz deleted the romanlutz/fix_typos branch July 28, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants