-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos in packaging doc #374
Fix typos in packaging doc #374
Conversation
Hi @romanlutz - thank you for your inputs. Can you please add the DCO (sign your commits - click on details in the workflow list above or below)? |
Hi @romanlutz and thanks for your contribution! To get this right, you also need to signoff your commit, normally you do it on each commit using
Or since there is only 1 commit here, I suggest you do a single commit rebase on your fix branch |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## dev #374 +/- ##
=======================================
Coverage 74.21% 74.21%
=======================================
Files 77 77
Lines 2637 2637
Branches 266 266
=======================================
Hits 1957 1957
Misses 598 598
Partials 82 82 |
Signed-off-by: Yasumasa Suenaga <[email protected]>
* cleaning workflows Signed-off-by: Dan Benitah <[email protected]> * pull request should on trigger for pull request event - removing on push for PRs Signed-off-by: Dan Benitah <[email protected]> * syntax Signed-off-by: Dan Benitah <[email protected]> * syntax Signed-off-by: Dan Benitah <[email protected]> * moving markdown linting and disabling 2.a-deploy Signed-off-by: Dan Benitah <[email protected]> * adding some jobs dependencies so packaging does not run if code does not build etc... Signed-off-by: Dan Benitah <[email protected]> * moving code analysis into the build step and clean up Signed-off-by: Dan Benitah <[email protected]> --------- Signed-off-by: Dan Benitah <[email protected]> Co-authored-by: danuw <[email protected]>
* Skip deploy workflows in forked repos Signed-off-by: Yasumasa Suenaga <[email protected]> * Add vars Signed-off-by: Yasumasa Suenaga <[email protected]> --------- Signed-off-by: Yasumasa Suenaga <[email protected]>
Signed-off-by: Roman Lutz <[email protected]>
9cec883
to
5347db6
Compare
…rbon-aware-sdk into romanlutz/fix_typos
LGTM |
Hey @danuw , if you will be merging this now, can you squash it? There seem to be some rebasing commits in the history (and double check the history please) |
LGTM EDIT: all green. Thank you for your contribution |
Pull Request
Issue Number: -
Summary
Fixing typos in the packaging doc
Changes
Checklist
Are there API Changes?
If yes, what are the expected API Changes? Please link to an API-Comparison
workflow with the API Diff.
Is this a breaking change?
If yes, what workflow does this break?
Anything else?
Other comments, collaborators, etc.