Keep installation popup open until server is successfully installed

This prevents closing it and reopening it every time the installation fails and also makes it consistent with the "Test my setup" flow. References #460
Gert-dev · Sep 14, 2019 · 2f8d94a · 2f8d94a
1 parent 5226a17
commit 2f8d94a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/SerenataClient.js b/lib/SerenataClient.js
@@ -81,13 +81,13 @@ class SerenataClient extends AutoLanguageClient
                     {
                         text: 'Yes',
                         onDidClick: () => {
-                            notification.dismiss();
-
                             const callback = async () => {
                                 if (!await this.installServer()) {
-                                    return await this.installServerIfNecessary();
+                                    reject(new Error('Server installation failed'));
+                                    return;
                                 }
 
+                                notification.dismiss();
                                 resolve();
                             };