Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for subgroup intrinsics, see GL_KHR_shader_subgroup and SPIRV spec 3.49.24. Non-Uniform Instructions.
Note that the glsl extension only exposes spirv's
OpGroupNonUniform*
instructions, and NOT theOpGroup*
instructions which can be found in 3.49.21. Group and Subgroup Instructions. As manyOpGroup*
instructions are only documented withReserved.
, I assume during development they decided against these and switched to theOpGroupNonUniform*
instructions.Open Questions:
OpGroupNonUniform*
, glsl calls themsubgroup*
. I've decided to name themsubgroup_non_uniform*
but I'm wondering if thenon_uniform
should be dropped as they all are non uniform?trait VectorOrScalar
. But glam's boolean vectors seem to behave weirdly and not work, not even the compiletestarch/any
uses them. So for now I've just left them unsupported.