-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] add #[spirv(typed_buffer)]
for explicit SpirvType::InterfaceBlock
s.
#1014
Draft
eddyb
wants to merge
25
commits into
EmbarkStudios:main
Choose a base branch
from
LykenSol:buffer-interface-block
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyb
force-pushed
the
buffer-interface-block
branch
from
March 21, 2023 05:27
fa61f1e
to
8f10f2a
Compare
eddyb
force-pushed
the
buffer-interface-block
branch
from
June 4, 2023 15:14
8f10f2a
to
d78df7e
Compare
eddyb
force-pushed
the
buffer-interface-block
branch
from
November 10, 2023 05:41
d78df7e
to
e7be758
Compare
eddyb
force-pushed
the
buffer-interface-block
branch
from
November 25, 2023 09:48
e7be758
to
225f773
Compare
eddyb
force-pushed
the
buffer-interface-block
branch
4 times, most recently
from
August 4, 2024 15:17
52445ce
to
e28b47f
Compare
eddyb
force-pushed
the
buffer-interface-block
branch
from
August 6, 2024 13:19
e28b47f
to
8ee360c
Compare
…e backend's `target_override`.
eddyb
force-pushed
the
buffer-interface-block
branch
from
August 9, 2024 01:03
8ee360c
to
9d6b34f
Compare
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened as draft because it's somewhat incomplete, but I want it out of the way for now.
This PR adds a
TypedBuffer<T>
"handle" type tospirv-std
(comparable toImage
types in some respects).While not a perfect representation of the Vulkan/SPIR-V buffer model, we can't do much better for now.
With
TypedBuffer<T>
, we can now redefine the existing usage patterns:as sugar1 for:
1 (which we will continue to support for the foreseeable future, presumably)
(comparable to
buffer { uint data[]; } storage_buffer;
in GLSL)That is, plain Rust references are used to describe a single buffer, with the Rust type (
MyConstData
or[u32]
) being for the buffer contents, used to interpret the raw bytes (provided to the host, e.g. Vulkan, API).Because the "buffer handle" is made explicit, specifying multiple buffers is unambiguous:
(comparable to
buffer { uint data[]; } storage_buffers[];
in GLSL)In other words, each
TypedBuffer
Rust value corresponds exactly to one buffer descriptor (e.g.VkBuffer
).TODO(@eddyb): add changelog, tests, discuss
UntypedBuffer
(TypedBuffer<[u32]>
wrapper), maybe deprecateByteAddressibleBuffer
(to rename it toByteAddressibleView
or something? unsure what's best here)