Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix where the gradient fill would not find the defining element, when url contains anchor (#) information #950

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pbastia
Copy link

@pbastia pbastia commented Mar 16, 2015

the gradient fill wouldn't find its defining elements from the svg defs section, because it is referred to in an absolute manner, and the url would include anchor (#) tags.

the url has been replaced with "document.location.pathname", which is the relative reference, and seems to be working.

I am not sure of the implications of this modifications, but the fix worked beautifully for me.

…ment because it is referred to in an absolute manner, and the url would include anchor (#) tags

the url has been replaced to document.location.pathname, which is the relative reference

I am not sure of the implications of this modifications, but the fix worked beautifully for me.
@qurben
Copy link

qurben commented Jul 14, 2015

See also #939, please merge this fix.

We are still stuck on an old version of Raphael (2.1.2 with bower or even 2.1.0 with browserify) where this doesn't occur and we would really like to use the new features of Raphael.

@dpogue
Copy link
Contributor

dpogue commented Jul 22, 2015

This is causing problems for us using Raphaël in an Angular app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants