GRIDEDIT-617 Added spline snapping to api #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacarniato
requested changes
Jul 31, 2023
| landBoundaryPoints[i] = meshkernel::Point({land.coordinates_x[i], land.coordinates_y[i]}); | ||
| } | ||
|
|
||
| for (int i = 0; i < splines.num_coordinates; ++i) |
There was a problem hiding this comment.
what if multiple splines are provided? start/end index refer to the selected spline corner's point
| meshkernel::LandBoundary landBoundary(landBoundaryPoints); | ||
| meshkernel::Splines splineValues(meshKernelState[meshKernelId].m_mesh2d->m_projection); | ||
|
|
||
| splineValues.AddSpline(splinePoints, startSplineIndex, static_cast<meshkernel::UInt>(splinePoints.size())); |
There was a problem hiding this comment.
suppose we pass to the API only the spline that needs to be snapped in a set of several splines, the startSplineIndex and endSplineIndex would not be required. what we need instead are the indices of the the corner points defining the portion of the spline that will be snapped
lucacarniato
approved these changes
Aug 2, 2023
BillSenior
deleted the
feature/GRIDEDIT-617_api_function_span_spline_to_land
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.