-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GRIDEDIT-247 First time for snapping spline to land boundary code #201
Merged
BillSenior
merged 37 commits into
master
from
feature/GRIDEDIT-247_snap_spline_to_land_boundary
Jul 25, 2023
Merged
GRIDEDIT-247 First time for snapping spline to land boundary code #201
BillSenior
merged 37 commits into
master
from
feature/GRIDEDIT-247_snap_spline_to_land_boundary
Jul 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the functionality contained in the LandBoundaries has been extracted and added to the newly created LandBoundary class. In future more functionality can be moved from the LandBoundaries to this new class.
Some of the functionality that was contained in the splines class has been extracted and placed in a SplineAlgorithms class, together with the new snapping of splines to land boundaries algorithm.
lucacarniato
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to add an API for this algorithm at meshkernelapi level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.