Fix readonly mode for buttons

DHI · Sep 8, 2023 · fa394da · fa394da
1 parent 5cacdd2
commit fa394da
Show file tree

Hide file tree

Showing 2 changed files with 48 additions and 49 deletions.
diff --git a/libs/jsonform/src/FormConfigEditor.tsx b/libs/jsonform/src/FormConfigEditor.tsx
@@ -251,51 +251,53 @@ export const FormConfigEditor = observer<{
             </Alert>
           )}
         </Grid>
-        <Grid
-          container
-          css={css`
-            flex-grow: 1;
-            justify-content: space-between;
-            padding: 1em 1.5em;
-            box-shadow: 0 -2px 3px 0 #0002, 0 1px 1px 0 #0001;
-            position: relative;
-          `}
-        >
-          <div>
-            <ConfirmDropdown
-              trigger={{
-                button: {
-                  variant: 'outlined',
-                  disabled: !!readOnly,
-                },
-                icon: <DiscardIcon fontSize="small" />,
-                label: <>{text?.discardButton || 'Discard'}</>,
-              }}
-              confirm={{
-                icon: <DiscardIcon />,
-                label: <>{text?.discardButton || 'Discard'}</>,
-                onClick() {
-                  operations?.onDiscard?.();
-                },
-              }}
-            />
-            <Button
-              color="primary"
-              variant="outlined"
-              endIcon={<SaveIcon fontSize="small" />}
-              onClick={() => {
-                state.validateEntireForm();
-
-                if (state.hasValidationErrors) return;
-
-                operations?.onSave?.(state.data);
-              }}
-              disabled={!!readOnly || state.hasValidationErrors}
-            >
-              {text?.saveButton || 'Save'}
-            </Button>
-          </div>
-        </Grid>
+        {!readOnly && (
+          <Grid
+            container
+            css={css`
+              flex-grow: 1;
+              justify-content: space-between;
+              padding: 1em 1.5em;
+              box-shadow: 0 -2px 3px 0 #0002, 0 1px 1px 0 #0001;
+              position: relative;
+            `}
+          >
+            <div>
+              <ConfirmDropdown
+                trigger={{
+                  button: {
+                    variant: 'outlined',
+                    disabled: !!readOnly,
+                  },
+                  icon: <DiscardIcon fontSize="small" />,
+                  label: <>{text?.discardButton || 'Discard'}</>,
+                }}
+                confirm={{
+                  icon: <DiscardIcon />,
+                  label: <>{text?.discardButton || 'Discard'}</>,
+                  onClick() {
+                    operations?.onDiscard?.();
+                  },
+                }}
+              />
+              <Button
+                color="primary"
+                variant="outlined"
+                endIcon={<SaveIcon fontSize="small" />}
+                onClick={() => {
+                  state.validateEntireForm();
+
+                  if (state.hasValidationErrors) return;
+
+                  operations?.onSave?.(state.data);
+                }}
+                disabled={!!readOnly || state.hasValidationErrors}
+              >
+                {text?.saveButton || 'Save'}
+              </Button>
+            </div>
+          </Grid>
+        )}
       </Grid>
     );
   },

diff --git a/libs/scenarios/src/editor/ScenarioConfigEditor.tsx b/libs/scenarios/src/editor/ScenarioConfigEditor.tsx
@@ -80,6 +80,7 @@ export const ScenarioConfigEditor = observer<{
 
             updateScenario({ ...activeScenario, data });
           },
+
           ...(editor.operations ?? {}),
         }}
       />
@@ -91,7 +92,6 @@ export const ScenarioConfigEditor = observer<{
             box-shadow: 0 2px 3px 0 #0002, 0 -1px 1px 0 #0001;
             position: relative;
           `}
-          disabled={!!editor.readOnly}
         >
           <ConfirmDropdown
             css={css`
@@ -100,9 +100,6 @@ export const ScenarioConfigEditor = observer<{
             trigger={{
               icon: <DeleteIcon />,
               label: <>Delete</>,
-              button: {
-                disabled: !!editor.readOnly,
-              },
             }}
             confirm={{
               icon: <DeleteIcon />,