Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Vite Plugin to remove data-testids unless testing #152

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

Yahatix
Copy link
Contributor

@Yahatix Yahatix commented Sep 15, 2023

What type of Pull Request is this?

Delete all options except for the one that applies

  • Feature
  • Build related changes

What is the current behavior?

data-testids are visible to end users which is unnecessary

Issue Number: N/A

What is the new behavior?

data-testids are removed unless we are testing

@Yahatix Yahatix force-pushed the feature/remove-testids-vite-plugin branch from 9d8b9a1 to 247356b Compare September 24, 2023 00:02
@w3cj w3cj merged commit a41aff2 into CodingGarden:main Sep 29, 2023
@Yahatix Yahatix deleted the feature/remove-testids-vite-plugin branch September 29, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants