Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show upsell popup when editing pro fields #373

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

girishpanchal30
Copy link
Contributor

@girishpanchal30 girishpanchal30 commented Sep 12, 2024

Summary

Added upsell popup and show it when editing the lock field if a license is expired or not available.

Will affect visual aspect of the product

YES

Screenshots

https://tinyurl.com/2bmmgwuf

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/ppom-pro/issues/381

@girishpanchal30 girishpanchal30 added the pr-checklist-skip Allow this Pull Request to skip checklist. label Sep 12, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Sep 12, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Sep 12, 2024

Plugin build for ffbc0bc is ready 🛎️!

@rodica-andronache
Copy link

@girishpanchal30 I've tested with no license entered at all.
In this case, I got these warnings
Screenshot on 2024-09-14 at 10-15-15

Also, after clicking on the Renew License button, I am redirected to this, not sure if correct
Screenshot on 2024-09-14 at 10-15-57

@girishpanchal30
Copy link
Contributor Author

@rodica-andronache I fixed the warnings and the Renew License URL is working for me, please check with the latest build zip.

@AndreeaCristinaRadacina

@girishpanchal30 I tested it now, and it works as expected!
image

One question: should we add an overlay to make the rest of the screen not accessible anymore?
Right now, while I have the alert on the screen, I can still perform other actions, like enabling/disabling fields:
image

I can even switch to the style tab and write some code.

@girishpanchal30
Copy link
Contributor Author

@AndreeaCristinaRadacina Added background overlay, please check with the latest commit.

@AndreeaCristinaRadacina

@girishpanchal30, perfect! It works as expected!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants