Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to disable private submission #4419

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Harshit28j
Copy link

@Harshit28j Harshit28j commented Aug 31, 2024

image

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 15.38462% with 22 lines in your changes missing coverage. Please review.

Project coverage is 68.91%. Comparing base (96968d6) to head (9d8b8fc).
Report is 1112 commits behind head on master.

Files with missing lines Patch % Lines
frontend/src/js/controllers/challengeCtrl.js 15.38% 22 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4419      +/-   ##
==========================================
- Coverage   72.93%   68.91%   -4.02%     
==========================================
  Files          83       20      -63     
  Lines        5368     3600    -1768     
==========================================
- Hits         3915     2481    -1434     
+ Misses       1453     1119     -334     
Files with missing lines Coverage Δ
frontend/src/js/controllers/challengeCtrl.js 60.57% <15.38%> (-13.13%) ⬇️

... and 63 files with indirect coverage changes

Files with missing lines Coverage Δ
frontend/src/js/controllers/challengeCtrl.js 60.57% <15.38%> (-13.13%) ⬇️

... and 63 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11ea23e...9d8b8fc. Read the comment docs.

Copy link
Collaborator

@gchhablani gchhablani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR!

In submission.html, make sure that this thing is disabled when the private submissions are disabled. i.e. don't give this option during submission.

image

In my-submission page, there is a bunch of logic here which shows a column to make an old/existing submission public or private. That column should only be visible when disable_private_submission is False:

image

Also, make sure to understand the logic here before making changes, will help with a sanity check.

Test it out locally using ngrok.
Try enable/disable using the config. And enable/disable using the edit option that you have added.
And add screenshot of the submit tab and my-submissions page in all four cases.

And a good to have: add this attribute to challenge config docs: https://evalai.readthedocs.io/en/latest/configuration.html

apps/challenges/views.py Outdated Show resolved Hide resolved
@Harshit28j
Copy link
Author

image
image

@Harshit28j
Copy link
Author

@gchhablani I have also tested this by hosting a challenge from EvalAI-Starters using challenge_config.yaml, adding the disable_private_submission attribute to a challenge, and also tested by upgrading its value.

@gchhablani
Copy link
Collaborator

@Harshit28j Can you share screenshot of the my submissions page too?

@Harshit28j
Copy link
Author

@gchhablani here:

  1. When the value of disable_private_submission = true
    image

  2. When the value of disable_private_submission = false
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants