use updated Bonan comparison artifact #900
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasloan25
changed the title
juliasloan25
force-pushed
the
js/bonan-artifact
branch
from
f0c0b05
to
8c0a334
Compare
12 tasks
Sbozzolo
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Use updated Bonan comparison dataset uploaded to ClimaArtifacts in CliMA/ClimaArtifacts#58.
Also moves the
vanGenuchteninner constructor out of the struct definition so we have access to the default constructor. We use this to use the same valuevg_m = 1as Bonan for the sand case.To-do
Content