Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helper functions for spatially varying params #883

Merged
merged 1 commit into from
Oct 29, 2024
Merged

helper functions for spatially varying params #883

merged 1 commit into from
Oct 29, 2024

Conversation

kmdeck
Copy link
Member

@kmdeck kmdeck commented Oct 23, 2024 •
edited
Loading

Purpose

Close #882

To-do

Content

  • I have read and checked the items on the review checklist.

@kmdeck kmdeck requested a review from Sbozzolo October 23, 2024 17:22
@kmdeck kmdeck force-pushed the kd/default_spatial_parameter_setup branch 2 times, most recently from 38da9cd to bdc94da Compare October 25, 2024 22:51
Sbozzolo
Sbozzolo reviewed Oct 28, 2024
View reviewed changes
experiments/benchmarks/richards.jl Outdated Show resolved Hide resolved
experiments/long_runs/land.jl Outdated Show resolved Hide resolved
experiments/long_runs/land_region.jl Outdated Show resolved Hide resolved
experiments/long_runs/soil.jl Show resolved Hide resolved
src/simulations/spatial_parameters.jl Outdated Show resolved Hide resolved
src/simulations/spatial_parameters.jl Outdated Show resolved Hide resolved
Sbozzolo
Sbozzolo approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@Sbozzolo Sbozzolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kmdeck kmdeck force-pushed the kd/default_spatial_parameter_setup branch from 1dd6f2e to 9df30a9 Compare October 29, 2024 19:55
@kmdeck kmdeck enabled auto-merge October 29, 2024 19:56
@kmdeck kmdeck mentioned this pull request Oct 29, 2024
Draft
@kmdeck kmdeck merged commit ab9ccad into main Oct 29, 2024
16 checks passed
@kmdeck kmdeck deleted the kd/default_spatial_parameter_setup branch October 29, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sbozzolo Sbozzolo Sbozzolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consolidate spatially varying parameters in sim setup
2 participants
@kmdeck @Sbozzolo