set NaNs to 1 #880
Merged
set NaNs to 1 #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also addresses PR #877 |
Espeer5
approved these changes
Oct 23, 2024
braghiere
requested changes
Oct 23, 2024
| ϕf = kf / (kf + kd + kn) * (1 - ϕp) | ||
| ϕp0 = kp / max(kf + kp + kn, eps(FT)) | ||
| ϕp = J / max(Jmax, eps(FT)) * ϕp0 | ||
| ϕf = kf / max(kf + kp + kn, eps(FT)) * (1 - ϕp) |
There was a problem hiding this comment.
I belive it is kd instead of kp. Eq (7) in:
Raczka, B., Porcar-Castell, A., Magney, T., Lee, J.E., Köhler, P., Frankenberg, C., Grossmann, K., Logan, B.A., Stutz, J., Blanken, P.D. and Burns, S.P., 2019. Sustained Nonphotochemical Quenching Shapes the Seasonal Pattern of Solar-Induced Fluorescence at a High-Elevation Evergreen Forest. Journal of Geophysical Research: Biogeosciences, 124(7), pp.2005- 2020. https://doi.org/10.1029/2018JG004883
There was a problem hiding this comment.
thanks Renato. let me make a quick PR to fix this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Sets clumping index to 1 if Nan in preprocessing of data.
Removes divide by zero in SIF measurement where canopy is not present.
Verified that Nans are not present in SIF and other output (besides canopy temp, which has NaNs where canopy is not present).
To-do
Content
Adds a nans_to_one function and uses in SpaceVaryingInput call.
Removes divide by zero in SIF measurement where canopy is not present by using max(VCmax25, eps(FT)), etc.