Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy long run artifacts #874

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Tidy long run artifacts #874

merged 1 commit into from
Oct 31, 2024

Conversation

AlexisRenchon
Copy link
Member

@AlexisRenchon AlexisRenchon commented Oct 21, 2024 •
edited
Loading

  • one .pdf instead of 36 .png artifacts in long runs
  • add diagnostic tests in CI pipeline

closes #730

@AlexisRenchon AlexisRenchon mentioned this pull request Oct 21, 2024
Closed
9 tasks
@AlexisRenchon AlexisRenchon force-pushed the ar/tidy_artifacts branch 3 times, most recently from 7390bd7 to 566d6c2 Compare October 21, 2024 22:27
@AlexisRenchon AlexisRenchon force-pushed the ar/tidy_artifacts branch 2 times, most recently from cb7c579 to 08f4d78 Compare October 22, 2024 15:58
@AlexisRenchon AlexisRenchon marked this pull request as ready for review October 22, 2024 15:59
@AlexisRenchon AlexisRenchon force-pushed the ar/tidy_artifacts branch 7 times, most recently from 19411c2 to f4e0215 Compare October 22, 2024 18:31
@AlexisRenchon AlexisRenchon self-assigned this Oct 22, 2024
@AlexisRenchon AlexisRenchon force-pushed the ar/tidy_artifacts branch 5 times, most recently from 3bbc5ea to 2f3b1e2 Compare October 25, 2024 17:20
@AlexisRenchon AlexisRenchon force-pushed the ar/tidy_artifacts branch 3 times, most recently from 5b35123 to 9ba5bdd Compare October 28, 2024 20:46
@AlexisRenchon AlexisRenchon force-pushed the ar/tidy_artifacts branch 5 times, most recently from 9c7ce11 to b393ee0 Compare October 30, 2024 22:15
@Sbozzolo
Copy link
Member

Sbozzolo commented Oct 31, 2024 •
edited
Loading

Benchmarks fail for unrelated reasons. I think this is ready to be merged once the conflict is solved

@AlexisRenchon
One .pdf instead of 36 .png long_runs artifacts
d5e75d1 
Long runs where producing 36 artifacts (.png files), this commit
tidy this up by gathering them into one .pdf instead.
@AlexisRenchon AlexisRenchon merged commit f6da5da into main Oct 31, 2024
16 of 17 checks passed
@AlexisRenchon AlexisRenchon deleted the ar/tidy_artifacts branch October 31, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sbozzolo Sbozzolo Sbozzolo approved these changes

Assignees

@AlexisRenchon AlexisRenchon

Labels
Diagnostics Run long runs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remaining to do for Diagnostics
2 participants
@AlexisRenchon @Sbozzolo