Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of specialized methods in stencil kernels #2043

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

charleskawczynski
Copy link
Member

This is another peel off from #2040.

@charleskawczynski
Copy link
Member Author

charleskawczynski commented Oct 16, 2024

Interesting, this seems to be needed for inference. Ah, there was a double space assignment.

@charleskawczynski
Copy link
Member Author

Interesting, this still fails in some relatively complex cases (e.g., our wfact opt examples). I think that this revealed that some of the functions in our window_bounds seems to either require inlining, or function barriers to pass JET tests, which reminds me of #1871.

@charleskawczynski
Copy link
Member Author

One thing I definitely found is that we need this definition:

strip_space_args(args::Tuple{Any}, space) =
    (strip_space(args[1], space), )

@charleskawczynski
Copy link
Member Author

Perhaps map((arg, width) -> arg - width[1], args_idx, widths) needs to be unrolled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant