Try to fix Undefined Behavior in DataLayouts #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
requested review from
dennisYatunin,
Sbozzolo and
juliasloan25
charleskawczynski
force-pushed
the
ck/attempt_to_fix_UB
branch
4 times, most recently
from
ffc8ee3
to
acee2e4
Compare
Sbozzolo
approved these changes
Oct 11, 2024
charleskawczynski
force-pushed
the
ck/attempt_to_fix_UB
branch
from
acee2e4
to
10f86ed
Compare
charleskawczynski
force-pushed
the
ck/attempt_to_fix_UB
branch
from
10f86ed
to
e5f1dac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per JuliaLang/julia#54780 (comment), this PR attempts to remove
string(::Type)inside a generated function.It seems to me like this code could be type-unstable, unless things are constant-propagated.