-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update configs (default topo smoothing) + add docs #3416
base: main
Are you sure you want to change the base?
Conversation
dbbe946
to
5d70432
Compare
@@ -51,7 +51,7 @@ topo_smoothing: | |||
value: false | |||
topography_damping_factor: | |||
help: "Factor by which smallest resolved length-scale is to be damped" | |||
value: 512 | |||
value: 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a pretty large change. What value should we use in the AMIP simulation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default value in the AMIP configuration initially was set up to match the outcome from the working Gaussian configuration in the coarse AMIP config. Ideally I'd like to use no more than 10-100x attenuation at the small scales if it's shown to be robust across all our configs. (The first iteration of this was perhaps overly conservative). This outcome of this PR is tested against the 16 element atmos longrun build result for now (up to 60days, results are accessible on central scratch
in the PR3416 dir). (Plots of the surface elevation for h_elem=16 are below as part of the doc assets. )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also try this in the nightly amip?
c63d392
to
be0f329
Compare
Decrease smoothing factor in default configuration Update functions in topography_spectra example file Update docs + plots modified: examples/topography_spectra.jl
c24f21c
to
e6d0937
Compare
I find it pretty hard to read the values from the plots with the colormap - is there a more quantitative colormap we can use? If it's hard then don't worry about it. |
Update default topo smoothing
Add docs demonstrating topo smoothing.