Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug CI times #3242

Closed
wants to merge 1 commit into from
Closed

Debug CI times #3242

wants to merge 1 commit into from

Conversation

charleskawczynski
Copy link
Member

No description provided.

@charleskawczynski
Copy link
Member Author

Looks like the compile times are from ClimaCore. I'll try bisecting

cc @szy21, @dennisYatunin

@charleskawczynski
Copy link
Member Author

charleskawczynski commented Aug 16, 2024

I'm going to use this snippet from PkgDevTools:

julia --project=examples

function with_precompile_set(fn; precompile=false)
    # ENV does not always have JULIA_PKG_PRECOMPILE_AUTO
    # precompile_value = ENV["JULIA_PKG_PRECOMPILE_AUTO"]
    x = "JULIA_PKG_PRECOMPILE_AUTO"
    precompile₀ = haskey(ENV, x) ? ENV[x] : nothing
    if !precompile
        @info "Temporarily setting ENV[$x] = 0"
        ENV[x] = 0
    end
    fn()
    if !precompile
        if isnothing(precompile₀); pop!(ENV, x)
        else; ENV[x] = precompile₀
        end
    end
    return precompile₀
end

using Pkg
with_precompile_set() do
	Pkg.add(PackageSpec(;name="ClimaCore", rev="ef82fe7cc8bae7fc638655c8ada6ed8fc5f627bc"))
end
  • ef82fe7 is good.
  • [98f4047] pending

@charleskawczynski
Copy link
Member Author

Bummer, it does seem to be from adding Nh as a static parameter. I'm not really sure why.

@szy21
Copy link
Member

szy21 commented Aug 16, 2024

Thanks for looking into this!

@charleskawczynski
Copy link
Member Author

I think that the result of this investigation lead to 3 findings:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants