Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low rank normalization #227

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Low rank normalization #227

merged 1 commit into from
Jul 21, 2023

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Jul 20, 2023

Purpose

Closes #225

Content

  • Based on the idea that the covariance defines geometrically a linear transformation from white noise to the data noise, ensemble covariance C can be viewed as C = R S S R^{-1} where R is a rotation, and S is the sqrt of the singular values of C. The transformation from white data to the actual data samples is C^{1/2} = RS and it's "whitening" inverse is C^{-1/2} = S^{-1}R^{-1} = S^{-1}R^T as R is a rotation. For rank deficient C, we take the normalization to be instead Sinv R^T where Sinv is Diagonal with the first rank(C) entries equal to S^{-1}, and zero otherwise.
  • Added tests to check the covariances become close to the identity in full or low-dim subspace after normalization
  • Changed an input-dim consistency check to account for new dimension change

  • I have read and checked the items on the review checklist.

@odunbar odunbar changed the title Low rank normalization [WIP] Low rank normalization Jul 20, 2023
@odunbar odunbar requested a review from eviatarbach July 20, 2023 19:51
@odunbar odunbar changed the title [WIP] Low rank normalization Low rank normalization Jul 20, 2023
Copy link

@eviatarbach eviatarbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing this! LGTM.

matrix order typo, and test for normalization

reduces dimension

change input dims check
@odunbar
Copy link
Collaborator Author

odunbar commented Jul 21, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 21, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 89724aa into main Jul 21, 2023
5 checks passed
@bors bors bot deleted the orad/low-rank-inputs branch July 21, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input normalization fails when ensemble size in EKI less than number of parameters
2 participants