fix: Delay take now error message by 500ms #520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error message is being shown before the navigation happens, so it ends up disappearing. We need to delay it a bit more, so it gets shown after navigation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
farmerpaul
approved these changes
Aug 6, 2024
|
Superseded by #539 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Note
This is a quick PR for something I noticed while recording a loom. No ticket exists for this fix
When a participant mismatch happens, they're supposed to be shown an error message so they can re-initiate take now from the admin panel. The error message is being shown before the navigation happens, so it ends up disappearing very quickly (possibly before being seen).
We need to delay it a bit more, so it gets shown after navigation. I've addd a 500ms delay to achieve this.
📸 Screenshots
Before
Banner disappears quickly
disappearing-banner-clip.mov
After
Banner persists
persistent-banner.mov
✏️ Notes
N/A