Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rendering for starfield #1952

Draft
wants to merge 44 commits into
base: master
Choose a base branch
from
Draft

New rendering for starfield #1952

wants to merge 44 commits into from

Conversation

375gnu
Copy link
Member

@375gnu 375gnu commented Oct 26, 2023

No description provided.

Askaniy
Askaniy reviewed Oct 26, 2023
View reviewed changes
shaders/star_vert.glsl Outdated Show resolved Hide resolved
375gnu
375gnu commented Oct 27, 2023
View reviewed changes
shaders/star_vert.glsl Outdated Show resolved Hide resolved
Askaniy
Askaniy reviewed Oct 27, 2023
View reviewed changes
shaders/star_vert.glsl Outdated Show resolved Hide resolved
375gnu
375gnu commented Oct 28, 2023
View reviewed changes
shaders/star_vert.glsl Outdated Show resolved Hide resolved
Askaniy
Askaniy reviewed Oct 28, 2023
View reviewed changes
shaders/star_vert.glsl Outdated Show resolved Hide resolved
375gnu
375gnu commented Oct 28, 2023
View reviewed changes
shaders/star_vert.glsl Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@375gnu 375gnu changed the title wip New rendering for starfield Nov 5, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 29, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

9 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Askaniy
Copy link
Member

Askaniy commented Jul 7, 2024

Summary:

  • Polishing the new star shader;
  • Complete redesign of the light calculation methods;
  • Automag was removed with the faintest magnitude system;
  • Star styles were removed;
  • Classic/Enhanced/Legacy star colors were removed;
  • Sun white point is default;
  • Astronomical constants updated to the latest standards;
  • Merged limb darkening branch.

ajtribick
ajtribick reviewed Jul 14, 2024
View reviewed changes
src/celastro/astro.h Outdated Show resolved Hide resolved
@ajtribick
Copy link
Collaborator

I can fix the conflicts with the master branch. Let me know if you prefer me to do this with a merge commit or rebasing this branch onto current master.

@Askaniy
Copy link
Member

Askaniy commented Jul 14, 2024

I'd appreciate it. Maybe, rebasing this branch onto current master? But that's more up to you

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 24, 2024

Quality Gate Passed Quality Gate passed

Issues
36 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajtribick ajtribick ajtribick left review comments

@Askaniy Askaniy Askaniy left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@375gnu @Askaniy @ajtribick