Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WeightAndSum pooling layer #263

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

aurorarossi
Copy link
Collaborator

This PR will add the WeightAndSum pooling layer (see issue #41)

@aurorarossi aurorarossi changed the title WeightAndSum pooling layer Add WeightAndSum pooling layer Mar 14, 2023
src/layers/pool.jl Outdated Show resolved Hide resolved
src/layers/pool.jl Outdated Show resolved Hide resolved
@aurorarossi aurorarossi marked this pull request as ready for review March 28, 2023 10:17
src/layers/pool.jl Outdated Show resolved Hide resolved
WeigthAndSumPool(in_feats)

WeigthAndSum sum pooling layer.
Takes a graph and the node features as inputs, computes the weights for each node and perform a weighted sum.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Takes a graph and the node features as inputs, computes the weights for each node and perform a weighted sum.
In the forward pass, takes a graph and the node features as inputs, computes the weights for each node and performs a weighted sum.

Should also describe how the weights are computed and describe the in_feats constructor argument.

Co-authored-by: Carlo Lucibello <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants