GlobalConcatPool #159
Draft
GlobalConcatPool #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
==========================================
- Coverage 85.45% 85.44% -0.01%
==========================================
Files 14 14
Lines 1299 1305 +6
==========================================
+ Hits 1110 1115 +5
- Misses 189 190 +1
Continue to review full report at Codecov.
|
src/layers/pool.jl
Outdated
Comment on lines
48
to
49
| GlobalConcatPool(aggr) | ||
|
|
|
Nice addition, thanks. Needs tests and a few words explaining the behavior in the docstring. |
Co-authored-by: Carlo Lucibello <[email protected]>
|
I changed it a bit, so any pooling layer can be used. Do you agree with this change? |
|
The test uses a GlobalPool layer, is this OK as it happens after the GlobalPool test, or should the test be fully isolated? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concatenates global features to the node features, is used to integrate global properties into the output of the nodes.