-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GlobalConcatPool #159
base: master
Are you sure you want to change the base?
GlobalConcatPool #159
Conversation
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
==========================================
- Coverage 85.45% 85.44% -0.01%
==========================================
Files 14 14
Lines 1299 1305 +6
==========================================
+ Hits 1110 1115 +5
- Misses 189 190 +1
Continue to review full report at Codecov.
|
src/layers/pool.jl
Outdated
GlobalConcatPool(aggr) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs a docstring
Nice addition, thanks. Needs tests and a few words explaining the behavior in the docstring. |
Co-authored-by: Carlo Lucibello <[email protected]>
I changed it a bit, so any pooling layer can be used. Do you agree with this change? |
The test uses a GlobalPool layer, is this OK as it happens after the GlobalPool test, or should the test be fully isolated? |
Concatenates global features to the node features, is used to integrate global properties into the output of the nodes.