Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Prisma iOS Code to New Repo #9

Merged
merged 17 commits into from
Jan 24, 2024
Merged

Migrate Prisma iOS Code to New Repo #9

merged 17 commits into from
Jan 24, 2024

Conversation

mjoerke
Copy link
Collaborator

@mjoerke mjoerke commented Jan 22, 2024

Migrate Prisma iOS Code to New Repo

♻️ Current situation & Problem

  • All Prisma code currently lives in the old iOS repository: https://github.com/StanfordHCI/prisma
  • All new contributions will be made to the course repository based on the Spezi 1.0 Template application
  • As such, we need to migrate the code from the old repository while updating the Prisma application to Spezi 1.0

⚙️ Release Notes

  • Updated icon, accent color, and app name
  • Update onboarding flow (removed consent and updated wording)
  • Updated HealthKit query to fetch additional data sources & fetch 1 month of historical data
  • Added placeholder surveys and updated the survey view
  • Updated the home screen with a placeholder chat tab
  • Updated the Standard to conform to our database format

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
N/A

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 306 lines in your changes are missing coverage. Please review.

Comparison is base (a340ac1) 40.90% compared to head (8203d3a) 40.41%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   40.90%   40.41%   -0.48%     
==========================================
  Files          30       36       +6     
  Lines         966     1220     +254     
==========================================
+ Hits          395      493      +98     
- Misses        571      727     +156     
Files Coverage Δ
Behavior/BehaviorDelegate.swift 95.66% <100.00%> (+0.58%) ⬆️
Behavior/Home.swift 76.32% <100.00%> (+3.59%) ⬆️
Behavior/Onboarding/OnboardingFlow.swift 96.88% <100.00%> (+0.33%) ⬆️
Behavior/Schedule/BehaviorScheduler.swift 100.00% <100.00%> (+16.13%) ⬆️
Behavior/Schedule/EventContext/EventContext.swift 100.00% <100.00%> (ø)
Behavior/Onboarding/Welcome.swift 96.08% <95.84%> (+1.49%) ⬆️
Behavior/Account/AccountSetupHeader.swift 0.00% <0.00%> (ø)
Behavior/Standard/Module.swift 0.00% <0.00%> (ø)
Behavior/Schedule/ScheduleView.swift 80.77% <72.23%> (+16.07%) ⬆️
Behavior/Chat/ChatView.swift 21.43% <21.43%> (ø)
... and 8 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a340ac1...8203d3a. Read the comment docs.

@mjoerke mjoerke self-assigned this Jan 24, 2024
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mjoerke 🚀

@mjoerke mjoerke merged commit a81085e into main Jan 24, 2024
7 checks passed
@mjoerke mjoerke deleted the matt/code-migration branch January 24, 2024 02:46
@mjoerke mjoerke added the enhancement New feature or request label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants