Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Testing #75

Merged
merged 10 commits into from
Mar 14, 2024
Merged

Adding Testing #75

merged 10 commits into from
Mar 14, 2024

Conversation

kcallon
Copy link
Contributor

@kcallon kcallon commented Mar 13, 2024

Initial Tests

♻️ Current situation & Problem

Link any open issues or pull requests (PRs) related to this PR. Please ensure that all non-trivial PRs are first tracked and discussed in an existing GitHub issue or discussion.

⚙️ Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@kcallon kcallon requested a review from zoyagarg March 14, 2024 03:56
Copy link
Contributor

@zoyagarg zoyagarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OKAY TESTING BAWSE !!! did someone say ... queen Kate!

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 19.43%. Comparing base (14e0ee7) to head (8ea0488).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            main      #75       +/-   ##
==========================================
+ Coverage   5.87%   19.43%   +13.57%     
==========================================
  Files         62       62               
  Lines       3632     3655       +23     
==========================================
+ Hits         213      710      +497     
+ Misses      3419     2945      -474     
Files Coverage Δ
Intake/Allergy Records/AllergyLLMAssistant.swift 0.00% <ø> (ø)
Intake/IntakeTestingSetup.swift 95.00% <100.00%> (+8.34%) ⬆️
...ake/Medication View/IntakeMedicationInstance.swift 100.00% <ø> (+100.00%) ⬆️
...ke/Medication View/IntakeMedicationViewModel.swift 80.77% <100.00%> (+80.77%) ⬆️
...ntake/Medication View/MedicationLLMAssistant.swift 33.34% <ø> (+33.34%) ⬆️
Intake/Home.swift 73.57% <80.00%> (+73.57%) ⬆️
Intake/Medication View/MedicationContentView.swift 94.60% <91.67%> (+94.60%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14e0ee7...8ea0488. Read the comment docs.

@zoyagarg zoyagarg merged commit 5659109 into main Mar 14, 2024
7 checks passed
@zoyagarg zoyagarg deleted the testing branch March 14, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants