Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back to 64 byte blocks for the market #49

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Back to 64 byte blocks for the market #49

wants to merge 4 commits into from

Conversation

brittcyr
Copy link
Contributor

image

@brittcyr
Copy link
Contributor Author

Will follow up with client code change after review of program

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 83.96947% with 21 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
programs/manifest/src/quantities.rs 74.57% 15 Missing ⚠️
...ams/manifest/src/program/processor/batch_update.rs 53.84% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

@brittcyr
Copy link
Contributor Author

without price caching, this is what I get
{
"name": "MFX_50",
"value": 8356,
"unit": "CU",
"range": "",
"extra": ""
},
{
"name": "MFX_95",
"value": 12343,
"unit": "CU",
"range": "",
"extra": ""
},
{
"name": "MFX_99",
"value": 13951,
"unit": "CU",
"range": "",
"extra": ""
}

a noticeable increase

@mschneider
Copy link
Contributor

we are still 5% away from target on the 50, adding 20% on top of that for a 25% decrease in rent (after we reduced it by 9999%) seems like a step in the wrong direction. It's trading an insignificant rent improvement for significant cu efficiency.

@brittcyr
Copy link
Contributor Author

we are still 5% away from target on the 50, adding 20% on top of that for a 25% decrease in rent (after we reduced it by 9999%) seems like a step in the wrong direction. It's trading an insignificant rent improvement for significant cu efficiency.

I'll keep this open in case we do want to try to cache things and squeeze back the CU, but agree that as it stands now, the decision would be no go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants