Skip to content

Commit

Permalink
Fix: SDKs changesets release (#2869)
Browse files Browse the repository at this point in the history
* add slack ping

* f

* fix

* fix publishing

* rl

* fix vue sdk

* add attw and publint

* comment out

* fix

* f
  • Loading branch information
samijaber committed Dec 5, 2023
1 parent 077e23c commit da956c3
Show file tree
Hide file tree
Showing 17 changed files with 194 additions and 34 deletions.
2 changes: 1 addition & 1 deletion .changeset/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
]
],
"linked": [],
"access": "restricted",
"access": "public",
"baseBranch": "main",
"updateInternalDependencies": "patch",
"ignore": [
Expand Down
5 changes: 5 additions & 0 deletions .changeset/itchy-garlics-turn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@builder.io/sdk-vue': patch
---

Fix publishing configuration
2 changes: 2 additions & 0 deletions .changeset/light-rabbits-grow.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
12 changes: 11 additions & 1 deletion .github/workflows/publish-sdks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,22 @@ jobs:
cache-node-modules: true
cache-install-state: true

- name: Create Release Pull Request & Publish to npm
- name: Create Release PR & Publish to npm
id: changesets
uses: changesets/action@v1
with:
publish: yarn workspace @builder.io/sdks ci:release
title: '📦 Publish SDKs'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_SDK_RELEASE_TOKEN }}
NODE_AUTH_TOKEN: ${{ secrets.NPM_SDK_RELEASE_TOKEN }}

# - name: Send Slack notification
# id: slack
# uses: slackapi/[email protected]
# with:
# payload: |
# { "publishedPackages": ${{ fromJson(steps.changesets.outputs.publishedPackages) }} }
# env:
# SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
6 changes: 4 additions & 2 deletions .yarnrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@ nodeLinker: node-modules

plugins:
- path: .yarn/plugins/@yarnpkg/plugin-version.cjs
spec: "@yarnpkg/plugin-version"
spec: '@yarnpkg/plugin-version'
- path: .yarn/plugins/@yarnpkg/plugin-workspace-tools.cjs
spec: "@yarnpkg/plugin-workspace-tools"
spec: '@yarnpkg/plugin-workspace-tools'

yarnPath: .yarn/releases/yarn-3.6.1.cjs

npmPublishAccess: 'public'
1 change: 0 additions & 1 deletion packages/sdks/output/nextjs/.npmrc

This file was deleted.

1 change: 0 additions & 1 deletion packages/sdks/output/qwik/.npmrc

This file was deleted.

1 change: 0 additions & 1 deletion packages/sdks/output/react-native/.npmrc

This file was deleted.

1 change: 0 additions & 1 deletion packages/sdks/output/react/.npmrc

This file was deleted.

1 change: 0 additions & 1 deletion packages/sdks/output/solid/.npmrc

This file was deleted.

2 changes: 1 addition & 1 deletion packages/sdks/output/solid/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@builder.io/sdk-solid",
"version": "0.7.1",
"version": "0.7.2-0",
"description": "",
"files": [
"dist",
Expand Down
1 change: 0 additions & 1 deletion packages/sdks/output/svelte/.npmrc

This file was deleted.

3 changes: 3 additions & 0 deletions packages/sdks/output/vue/.attw.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"excludeEntrypoints": ["css", "vue2/css", "vue3/css"]
}
1 change: 0 additions & 1 deletion packages/sdks/output/vue/.npmrc

This file was deleted.

4 changes: 4 additions & 0 deletions packages/sdks/output/vue/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
"main": "./vue3/lib/node/index.cjs",
"module": "./vue3/lib/node/index.js",
"type": "module",
"workspaces": [
"vue2",
"vue3"
],
"files": [
"vue2/lib",
"vue2/css/package.json",
Expand Down
5 changes: 5 additions & 0 deletions packages/sdks/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@
"lint": "yarn run prettier --write && yarn run eslint --fix",
"eslint": "eslint . --quiet",
"eslint:watch": "watch 'yarn run eslint' ./src ./overrides",
"g:publint": "cd $INIT_CWD && publint",
"g:attw": "cd $INIT_CWD && attw --pack .",
"g:pkg:lint": "cd $INIT_CWD && yarn g:publint && yarn g:attw",
"typecheck": "tsc --noEmit",
"typecheck:watch": "yarn run typecheck --watch",
"ci:lint:sdks": "yarn run prettier --check && yarn run eslint",
Expand Down Expand Up @@ -77,6 +80,7 @@
"traverse": "^0.6.6"
},
"devDependencies": {
"@arethetypeswrong/cli": "^0.13.3",
"@builder.io/eslint-plugin-mitosis": "^0.0.15",
"@types/node-fetch": "^2.5.12",
"@types/seedrandom": "^3.0.4",
Expand All @@ -93,6 +97,7 @@
"npm-run-all": "^4.1.5",
"pinst": "^3.0.0",
"prettier": "^2.5.0",
"publint": "^0.2.6",
"typescript": "^5.1.6",
"vitest": "^0.33.0",
"watch": "^1.0.2"
Expand Down
Loading

0 comments on commit da956c3

Please sign in to comment.