Skip to content

Commit

Permalink
Merge pull request #170 from BrianPugh/dep-py38
Browse files Browse the repository at this point in the history
drop python3.8 support.
  • Loading branch information
BrianPugh authored Oct 10, 2024
2 parents dbe3f01 + 35f069c commit 22f4c6b
Show file tree
Hide file tree
Showing 9 changed files with 450 additions and 470 deletions.
7 changes: 6 additions & 1 deletion .github/workflows/build_wheels.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ jobs:
fetch-depth: 0

- name: Set up python ${{ env.PYTHON }}
id: setup-python
uses: actions/setup-python@v5
with:
python-version: ${{ env.PYTHON }}
Expand All @@ -31,7 +32,7 @@ jobs:
id: cached-poetry
with:
path: ${{ env.POETRY_HOME }}
key: poetry-cache-${{ runner.os }}-${{ env.PYTHON }}-${{ hashFiles('.github/workflows/build_wheels.yaml') }}
key: poetry-cache-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-${{ hashFiles('.github/workflows/build_wheels.yaml') }}

- name: Install poetry
if: steps.cached-poetry.outputs.cache-hit != 'true'
Expand Down Expand Up @@ -90,6 +91,7 @@ jobs:

- name: Set up python ${{ env.PYTHON }}
uses: actions/setup-python@v5
id: setup-python
with:
python-version: ${{ env.PYTHON }}

Expand Down Expand Up @@ -138,6 +140,7 @@ jobs:

- name: Set up python ${{ env.PYTHON }}
uses: actions/setup-python@v5
id: setup-python
with:
python-version: ${{ env.PYTHON }}

Expand Down Expand Up @@ -179,6 +182,7 @@ jobs:

- name: Set up python ${{ env.PYTHON }}
uses: actions/setup-python@v5
id: setup-python
with:
python-version: ${{ env.PYTHON }}

Expand Down Expand Up @@ -211,6 +215,7 @@ jobs:
fetch-depth: 0

- uses: actions/setup-python@v5
id: setup-python
with:
python-version: "3.12"

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
id: cached-poetry
with:
path: ${{ env.POETRY_HOME }}
key: poetry-cache-${{ runner.os }}-${{ env.PYTHON }}-${{ hashFiles('.github/workflows/deploy.yaml') }}
key: poetry-cache-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-${{ hashFiles('.github/workflows/deploy.yaml') }}

- name: Install poetry
uses: snok/install-poetry@v1
Expand All @@ -51,7 +51,7 @@ jobs:
id: cached-venv
with:
path: .venv/
key: venv-cache-${{ runner.os }}-${{ env.PYTHON }}-${{ hashFiles('.github/workflows/deploy.yaml') }}
key: venv-cache-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-${{ hashFiles('.github/workflows/deploy.yaml') }}

- name: Install project
run: poetry install --no-interaction
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-13, windows-latest]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
python-version: ["3.9", "3.10", "3.11", "3.12"]
env:
OS: ${{ matrix.os }}
PYTHON: ${{ matrix.python-version }}
Expand Down Expand Up @@ -56,7 +56,7 @@ jobs:
id: cached-poetry
with:
path: ${{ env.POETRY_HOME }}
key: poetry-cache-${{ runner.os }}-${{ env.PYTHON }}-${{ hashFiles('.github/workflows/tests.yaml') }}
key: poetry-cache-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-${{ hashFiles('.github/workflows/tests.yaml') }}

- name: Install poetry
uses: snok/install-poetry@v1
Expand All @@ -77,7 +77,7 @@ jobs:
id: cached-venv
with:
path: .venv/
key: venv-cache-${{ runner.os }}-${{ env.PYTHON }}-${{ hashFiles('.github/workflows/tests.yaml') }}
key: venv-cache-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-${{ hashFiles('.github/workflows/tests.yaml') }}

- name: Install library
run: poetry install --no-interaction
Expand Down
2 changes: 1 addition & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ this template at https://github.com/BrianPugh/python-template .
.. |GHA tests| image:: https://github.com/BrianPugh/python-template/workflows/tests/badge.svg
:target: https://github.com/BrianPugh/python-template/actions?query=workflow%3Atests
:alt: GHA Status
.. |Python compat| image:: https://img.shields.io/badge/>=python-3.8-blue.svg
.. |Python compat| image:: https://img.shields.io/badge/>=python-3.9-blue.svg

.. _Codecov Dashboard: https://app.codecov.io/gh
.. _Docker: https://www.docker.com
Expand Down
4 changes: 2 additions & 2 deletions README_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

<div align="center">

![Python compat](https://img.shields.io/badge/%3E=python-3.8-blue.svg)
![Python compat](https://img.shields.io/badge/%3E=python-3.9-blue.svg)
[![PyPi](https://img.shields.io/pypi/v/GIT_REPONAME.svg)](https://pypi.python.org/pypi/GIT_REPONAME)
[![GHA Status](https://github.com/GIT_USERNAME/GIT_REPONAME/actions/workflows/tests.yaml/badge.svg?branch=main)](https://github.com/GIT_USERNAME/GIT_REPONAME/actions?query=workflow%3Atests)
[![Coverage](https://codecov.io/github/GIT_USERNAME/GIT_REPONAME/coverage.svg?branch=main)](https://codecov.io/github/GIT_USERNAME/GIT_REPONAME?branch=main)
Expand All @@ -19,7 +19,7 @@ pythontemplate is a
# Features

# Installation
pythontemplate requires Python `>=3.8` and can be installed via:
pythontemplate requires Python `>=3.9` and can be installed via:

```bash
python -m pip install git+https://github.com/GIT_USERNAME/GIT_REPONAME.git
Expand Down
4 changes: 2 additions & 2 deletions README_TEMPLATE.rst
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Features
Installation
============

pythontemplate requires Python ``>=3.8`` and can be installed via:
pythontemplate requires Python ``>=3.9`` and can be installed via:

.. code-block:: bash
Expand All @@ -42,6 +42,6 @@ Usage
.. |readthedocs| image:: https://readthedocs.org/projects/GIT_REPONAME/badge/?version=latest
:target: https://GIT_REPONAME.readthedocs.io/en/latest/?badge=latest
:alt: Documentation Status
.. |Python compat| image:: https://img.shields.io/badge/>=python-3.8-blue.svg
.. |Python compat| image:: https://img.shields.io/badge/>=python-3.9-blue.svg
.. |PyPi| image:: https://img.shields.io/pypi/v/pythontemplate.svg
:target: https://pypi.python.org/pypi/pythontemplate
2 changes: 1 addition & 1 deletion docs/source/Installation.rst
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Installation
============

pythontemplate requires Python ``>=3.8`` and can be installed from pypi via:
pythontemplate requires Python ``>=3.9`` and can be installed from pypi via:

.. code-block:: bash
Expand Down
Loading

0 comments on commit 22f4c6b

Please sign in to comment.