Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fairchecker button live deploys #774

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Conversation

albangaignard
Copy link
Contributor

Replaced BMUSE button by calls to the FAIR-Checker API. Two buttons: one for metdata harvesting, and one for Bioschemas profile validation.

@albangaignard
Copy link
Contributor Author

Here is how it looks like :
Capture d’écran 2023-06-21 à 17 50 54

Copy link
Contributor

@ljgarcia ljgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albangaignard could you please run some more tests? It does not work with some live deploys, for instance:

What could be happening with those not working with the API but with the website?

I would also suggest to include in this PR a new section FAIRChecker in https://bioschemas.org/tutorials/howto/howto_check_deploy so people can get some tips on why the validation could not work for their page

Thanks

@ljgarcia
Copy link
Contributor

Hi @albangaignard any news on this PR? Thanks

1 similar comment
@ljgarcia
Copy link
Contributor

ljgarcia commented Sep 6, 2023

Hi @albangaignard any news on this PR? Thanks

@albangaignard
Copy link
Contributor Author

albangaignard commented Sep 6, 2023

Hi @ljgarcia, thanks for coming back to me.

If we take this example https://zbmed.github.io/damalos/, here is the output of the periodic checks (https://github.com/BioSchemas/bioschemas-validation) :

URL HTTP_status nb_triples has_conforms_to info
9 https://zbmed.github.io/damalos/ 200 75 0 nan

This means that harvesting is ok, we can retrieve 75 RDF triples.

Then, there is no conformsTo property. We chose to evaluate Bioschemas profiles only when a conformsTo is specified.
It explains why there is no results for validation with the API.

On the FAIR-Checker website, we have another strategy, we try to infer the profile based on rdf:type properties. I have ongoing work to identify the "closest" profile but it's not "production" ready.

Is it clearer ?

@albangaignard
Copy link
Contributor Author

Here is the output from the FC website :

Capture d’écran 2023-09-06 à 13 30 23

Copy link
Contributor

@ljgarcia ljgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking, looks good

@ljgarcia ljgarcia merged commit 210f73e into master Sep 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants