Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a minor mistake made in the "Splice method in array" section in Day 1, as well as restructures some code for clarity.
Mistake with removing all elements using
splice
Originally, the Day 1 tutorial claimed that the following code would remove all items:
While
numbers.splice()
does return an empty list, it does not remove any items fromnumbers
.This can be seen in this demo.
Printing contents of
numbers
As a corollary, it would be more informative to print the actual contents of
numbers
rather than the return values of the methods called onnumbers
, especially becausesplice
modifies the array in-place.