Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom code branch1 #14701

Closed

Conversation

KhwajaYousuf
Copy link

Description

Refactor code for enhanced readability and adherence to Python conventions. The primary focus is on maintaining the original logic while making improvements to the coding style. The changes include:

  • Corrected import name for Processed class.
  • Renamed function convertExpr2Expression to convert_expr_to_expression.
  • Added docstrings to functions for better documentation.
  • Improved comments throughout the code for clearer understanding.
  • Adjusted indentation in the run method to enhance readability.

This commit does not fix any specific issues, but aims to improve code quality and maintainability.

Checklist:

@AUTOMATIC1111
Copy link
Owner

From Contributing:

  • Do not add multiple unrelated things in same PR.
  • Do not submit PRs where you just take existing lines and reformat them without changing what they do.

@akx
Copy link
Collaborator

akx commented Jan 20, 2024

You're not targeting dev, and these changes, like those from your previous PRs #14654, #14679, #14680 simply don't work. Renaming an edit_button variable to new_customize_button doesn't make a new_customize_button miraculously get set.

@KhwajaYousuf
Copy link
Author

KhwajaYousuf commented Jan 21, 2024 via email

@AUTOMATIC1111
Copy link
Owner

You have not hindered work but please read the https://github.com/AUTOMATIC1111/stable-diffusion-webui/wiki/Contributing page if you want to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants