Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update extra_networks_lora.py #12361

Closed
wants to merge 1 commit into from
Closed

Update extra_networks_lora.py #12361

wants to merge 1 commit into from

Conversation

Amadeus-AI
Copy link

Add type check for params.positional[2]

Description

  • A simple fix for compatibility with loRA block weight extension, which use params.positional[2] in string.
  • Prevent doing float(params.positional[2]) without checking the type of params.positional[2] (if its str).

Screenshots/videos:

Checklist:

@Amadeus-AI
Update extra_networks_lora.py
a18f8ae 
Add type check for params.positional[2]
@Amadeus-AI Amadeus-AI changed the base branch from master to dev August 6, 2023 05:35
@Amadeus-AI Amadeus-AI closed this Aug 6, 2023
@Amadeus-AI Amadeus-AI reopened this Aug 6, 2023
@Amadeus-AI Amadeus-AI closed this Aug 6, 2023
@Amadeus-AI Amadeus-AI deleted the positional_check branch August 6, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AUTOMATIC1111 AUTOMATIC1111 Awaiting requested review from AUTOMATIC1111 AUTOMATIC1111 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Amadeus-AI