-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use gfpgan stable codebase #12252
Conversation
it seems i can not re trigger the https://github.com/AUTOMATIC1111/stable-diffusion-webui/actions/runs/5736676815/job/15546757906?pr=12252 , since i change the target branch to |
the workflow it's only triggered on that workflow is only meant as a warning triggered when someone tries to commit to the master branch if you really want the warning gone, close then re-open the this pr |
is something improved |
if this gets merged I would suggest using the hash as opposed to the tag |
i've try to close and reopen this PR, but the warnning CI job not disappear. @w-e-w lol |
1 similar comment
i've try to close and reopen this PR, but the warnning CI job not disappear. @w-e-w lol |
ah I see but it's really just something that to tell new developers that you should base your code off of dev branch instead of master |
emmmm, Is there anything else I need to do on this? |
You need to explain what the reason is for updating to a newer version of GFPGAN. |
Actually I think 1.3.8 is what we use - it's in requirements_versions.txt. Maybe we don't need that installation code in the launcher at all. |
Ok, I initially thought this was designed to use a fixed version of the software, as a feature supplement But after reading the commit record and requirement file, it seems that this is the place that is left out. Currently the requirement file contains the correct 1.3.8 version, but this is ignored in launch? Perhaps the same version should be installed when installing in the bottom of the bag here? |
no, no, it's not ignored, if you check your installed pip version in webui's venv you would probably have 1.3.8 - I do. it is installed in launch_utils.py, line 399. |
I checked on a new installation that GFPGAN_PACKAGE is not needed and pushed a change that removes that part of launch_utils. |
Description
The WebUI project, currently using the GFPGAN code version, comes from an unstable version, taken from a temporary commit after the release of 1.3.5.
For consistency, refer to the requirements file, it is recommended to use version 1.3.8 of the stable version.
Checklist: