feature(Notifications): Add methods for handling unread notifications #2469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunstefix
commented
Oct 30, 2024
| this.initialize(); | ||
| const subscriptions: Array<ChannelInfo> = await this._pushClient!.notification.subscriptions({ | ||
| channel: this._akashaChannelAccount, | ||
| }); | ||
| if (!subscriptions.length) throw new Error('There is no settings for this channel'); | ||
| const channelSubscriptionInfo = subscriptions[0]; | ||
| let userSettings: UserSetting[] = []; | ||
| let userSettings: unknown[] = []; |
There was a problem hiding this comment.
This interface didn't exist in original branch so i used unknown to temporarily fix error
Deploying akasha-core-framework with
|
| Latest commit: |
e1461bd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://39367285.akasha-world-framework.pages.dev |
| Branch Preview URL: | https://dev-407.akasha-world-framework.pages.dev |
kenshyx
reviewed
Oct 30, 2024
| body: string; | ||
| title: string; | ||
| }; | ||
| secret: string; |
There was a problem hiding this comment.
couldn't this be used as a ReturnType from the push sdk?
There was a problem hiding this comment.
The return type they have in declaration file of sdk is any, so I created an interface for it manually.
kenshyx
reviewed
Oct 30, 2024
| @@ -19,6 +36,8 @@ class PushProtocol { | |||
| private _pushClient?: PushAPI; | |||
| private _notificationsStream?: PushStream; | |||
| private _akashaChannelAccount = '0x7Ebe714066149bEef3c2f60cC89eadF50Da23C26'; | |||
| private _unreadNotifications: PushOrgNotification[] = []; | |||
| public readonly lastestSeenSidKey = 'lastestSeenSidKey'; | |||
There was a problem hiding this comment.
this needs to be prefixed with the current authenticated did
There was a problem hiding this comment.
added a method that prepends it
There was a problem hiding this comment.
I think this contains also a typo, shouldn't it be latestSeen..?
kenshyx
reviewed
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues that will be closed
Testing
Checklist