Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix git client's ownership issue while running pre-commit #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix git client's ownership issue while running pre-commit #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
863e008
fix git client's ownership issue while running pre-commit
tchiaspko Jul 15, 2023
918565c
moved the git config command during the image build
tchia04 Jul 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ RUN set -eux; \
groupadd -r tox --gid=10000; \
useradd --no-log-init -r -g tox -m --uid=10000 tox; \
mkdir /tests; \
chown tox:tox /tests
chown tox:tox /tests \
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon. Must be chown tox:tox /tests; \

git config --system --add safe.directory /tests

WORKDIR /tests
VOLUME /tests
Expand All @@ -77,4 +78,4 @@ COPY docker-entrypoint.sh /usr/local/bin/

ENTRYPOINT ["docker-entrypoint.sh"]
USER tox
CMD ["tox"]
CMD ["tox"]
2 changes: 1 addition & 1 deletion docker-entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ if [ "${1#-}" != "$1" ] || [ -n "$isLikelyTox" ]; then
set -- tox "$@"
fi

exec "$@"
exec "$@"