Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User should receive a warning when the given data set can not cover the target grid. #14

Open
BSchilperoort opened this issue Oct 2, 2023 · 2 comments
Labels
most_common Issues related to the most_common regridder

Comments

@BSchilperoort
Copy link
Contributor

I think the user should receive a warning when the given data set can not cover the target grid. So it is better to have an extra check here. Currently, if that is the case, the regridder still works, but user will get a field with only 0 outside of the area covered by the original data.

Originally posted by @geek-yang in #12 (comment)

@BSchilperoort BSchilperoort added the most_common Issues related to the most_common regridder label Feb 8, 2024
@BSchilperoort BSchilperoort changed the title (most_common) User should receive a warning when the given data set can not cover the target grid. User should receive a warning when the given data set can not cover the target grid. Feb 8, 2024
@BSchilperoort
Copy link
Contributor Author

Additionally, we should check if the new resolution is finer than the old one. In that case an error should be raised instructing the user to use something like nearest-neighbor

@BSchilperoort
Copy link
Contributor Author

#31 made sure that the code won't fail. However, we should still give a warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
most_common Issues related to the most_common regridder
Projects
None yet
Development

No branches or pull requests

1 participant