[Order filtering] Filtering orders by product screen contains a filter button that is broken #12643
+28
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
backwardstruck
commented
Sep 18, 2024
| @@ -397,7 +397,7 @@ | |||
| android:name="productId" | |||
| app:argType="long" /> | |||
| <argument | |||
| android:name="allowedVatiations" | |||
| android:name="allowedVariations" | |||
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
…roduct-screen-contains-a-filter-button-that-is-broken
|
Found 1 violations: The PR caused the following dependency changes:expand
-+--- androidx.databinding:viewbinding:8.5.1
++--- androidx.databinding:viewbinding:8.4.0
+--- project :libs:cardreader
| \--- com.stripe:stripeterminal-localmobile:3.7.1
-| \--- androidx.databinding:viewbinding:8.2.2 -> 8.5.1 (*)
+| \--- androidx.databinding:viewbinding:8.2.2 -> 8.4.0 (*)
\--- org.wordpress:mediapicker:0.3.1
- \--- androidx.databinding:viewbinding:8.1.0 -> 8.5.1 (*)
+ \--- androidx.databinding:viewbinding:8.1.0 -> 8.4.0 (*)
Please review and act accordingly
|
backwardstruck
added
the
status: do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #12623
Description
Addresses an issue where the filter button on the product selection screen is non-responsive. The problem was due to the navigation action not being correctly recognized.
Steps to reproduce
Expected Behavior:
Testing information
Devices Used: tablet emulator
Affected Areas:
The tests that have been performed
Verified the navigation works as expected for the filter button.
Ensured dark mode compatibility for the filter screen.
Conducted smoke tests to confirm no regressions in navigation flow.
I have considered if this change warrants release notes and have added them to
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: