Issue/12597 custom fields banner #12601
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hichamboushaba
commented
Sep 12, 2024
Comment on lines
+53
to
+61
| private val appPrefs: AppPrefsWrapper = mock { | ||
| val bannerDismissed = MutableStateFlow(false) | ||
| on { observePrefs() }.thenReturn(bannerDismissed.map { Unit }) | ||
| on { isCustomFieldsTopBannerDismissed } doAnswer { bannerDismissed.value } | ||
| on { isCustomFieldsTopBannerDismissed = any() }.then { invocation -> | ||
| bannerDismissed.update { invocation.arguments[0] as Boolean } | ||
| } | ||
| } |
There was a problem hiding this comment.
This works more like a fake than a mock, and allows for a more thorough testing (we can simulate the dismiss properly).
hichamboushaba
added
type: enhancement
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
hichamboushaba
force-pushed
the
issue/12597-custom-fields-banner
branch
from
89982ce
to
bb72363
Compare
hichamboushaba
requested review from
JorgeMucientes and
irfano
and removed request for
JorgeMucientes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #12597
Description
This PR adds a banner to the custom fields list screen to show a message that would help explaining how the saving works for them, in contrast to how it works in the other parts of the Product Details.
For more information on why we need this and how we reached this decision please check this discussion p1725968896022239/1725948493.332539-slack-C03L1NF1EA3
Steps to reproduce
Testing information
The tests that have been performed
The above.
Images/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: