Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new sample: Mirroring and recording video from camera stream #1626

Open
4 tasks done
stepancar opened this issue Sep 20, 2023 · 2 comments
Open
4 tasks done

Add new sample: Mirroring and recording video from camera stream #1626

stepancar opened this issue Sep 20, 2023 · 2 comments

Comments

@stepancar
Copy link

stepancar commented Sep 20, 2023

  • I understand that issues created here are only relevant to the samples in this repo - not browser or SDK bugs
  • I have provided steps to reproduce
  • I have provided browser name and version
  • I have provided a link to the sample here or a modified version thereof

Note: If the checkboxes above are not checked (which you do after the issue is posted), the issue will be closed.

Description

Hello!
I want to add new sample which demonstrates mirroring video stream from camera and recording with media encoder.
In that sample I want to highlight difference between processing video in main thread and in web worker.

This is a prototype
https://stepancar.github.io/webrtc-samples/src/content/insertable-streams/video-recording/

Any concerns?

@stepancar stepancar changed the title Mirroring and recording video from camera stream Add new sample: Mirroring and recording video from camera stream Sep 20, 2023
@crizmo
Copy link

crizmo commented Nov 7, 2023

Thanks !!

@stepancar
Copy link
Author

Hello @fippo!

I noticed you are reviewing, merging PRs in this repo,
I tried to follow contribution guide to contribute to samples, but didn't get any feedback.
Created this thread https://groups.google.com/g/discuss-webrtc/c/Z-_Pwbm9xP0/m/BwA0d-1sBgAJ but didn't get any feedback there too
This issue has an attached PR.
Could you please validate the idea, and implementation if the idea makes sense?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants