Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify looking up attribute name in Xeroizer models #436

Open
nnc opened this issue Jun 9, 2018 · 0 comments
Open

Unify looking up attribute name in Xeroizer models #436

nnc opened this issue Jun 9, 2018 · 0 comments
Labels

Comments

@nnc
Copy link
Contributor

nnc commented Jun 9, 2018

In #419 @stellard made the change to raise a more helpful error when you get the attribute name wrong, which is very helpful btw, but it was limited only to the .build method, while #attributes= still suffers the same issue as .build did before.

This is mostly a reminder to self to unify these two lookups into a common method, so they both raise the more helpful error.
But if anyone else feels like it, please go ahead and submit a pull request, as I'm not at all sure when I'll be able to get around to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants