Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document filters and modifiers #3

Open
h2non opened this issue Apr 8, 2016 · 5 comments
Open

Document filters and modifiers #3

h2non opened this issue Apr 8, 2016 · 5 comments

Comments

@h2non
Copy link
Member

h2non commented Apr 8, 2016

Perhaps change the semantic to Mapper or Rewriter

@h2non
Copy link
Member Author

h2non commented Apr 8, 2016

@groyoh Makes more sense to you changing the Modifier semantic into Rewriter or Mapper? The idea is to bind custom functions to adapt/modify/transform the request object before it will be dispatched as part of the replay pipeline.

@groyoh
Copy link
Member

groyoh commented Apr 8, 2016

What's wrong with Modifier?

@h2non
Copy link
Member Author

h2non commented Apr 8, 2016

Nothing in particular, but in other packages we're using a different semantic, such as Mapper and Rewriter. The purpose of them is almost the same, so I was just thinking it we could tend to unify this, also to become more idiomatic across packages.

@groyoh
Copy link
Member

groyoh commented Apr 8, 2016

I think Rewriter would make more sense is such case. Mapper feels more related to the act of binding rather than transforming. In the end, I still prefer Modifier over the others.

@h2non
Copy link
Member Author

h2non commented Apr 8, 2016

Sounds good to me. Let's keep it as Modifier for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants