Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android][iOS] Changing Padding from SizeChanged handler doesn't update the layout #13351

Open
ramezgerges opened this issue Aug 22, 2023 · 2 comments
Open

[Android][iOS] Changing Padding from SizeChanged handler doesn't update the layout #13351

ramezgerges opened this issue Aug 22, 2023 · 2 comments
Labels
difficulty/challenging 🤯 Categorizes an issue for which the difficulty level is reachable with internals understanding kind/bug Something isn't working platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform project/layout 🧱 Categorizes an issue or PR as relevant to layouting and containers (Measure/Arrange, Collections,..)

Comments

@ramezgerges
Copy link
Contributor

ramezgerges commented Aug 22, 2023 •
edited
Loading

Current behavior

This is a followup to #7978 with runtime tests being added in #13263. The original problem with Padding and SizeChanged was that PaddingProperty didn't have AffectsMeasure, which fixed the issue on the other platforms, but on iOS and Android, the Panel still doesn't update its layout despite the fact that the IsMeasureDirty flag is true.

Expected behavior

Panels should update their layouts when Padding changes (and specifically in SizeChanged).

How to reproduce it (as minimally and precisely as possible)

Check out the runtime tests at #13263

Workaround

Manually call panel.InvalidateMeasure() (and then possibly panel.UpdateLayout())

Works on UWP/WinUI

Yes

Environment

No response

NuGet package version(s)

No response

Affected platforms

Android, iOS

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response
@ramezgerges ramezgerges added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Aug 22, 2023
@MartinZikmund
Copy link
Member

I think @carldebilly may know the reason behind this

@MartinZikmund MartinZikmund added difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform and removed triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Aug 23, 2023
@jeromelaban jeromelaban added the project/layout 🧱 Categorizes an issue or PR as relevant to layouting and containers (Measure/Arrange, Collections,..) label Aug 23, 2023
@Soap-141 Soap-141 mentioned this issue Oct 18, 2023
Open
@MartinZikmund MartinZikmund changed the title [Android][iOS] Changing Padding from SizeChanged handler doesn't update the layout [Android][iOS] Changing Padding from SizeChanged handler doesn't update the layout Oct 23, 2023
@MartinZikmund MartinZikmund added difficulty/challenging 🤯 Categorizes an issue for which the difficulty level is reachable with internals understanding and removed difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI labels Oct 23, 2023
@Youssef1313
Copy link
Member

This will likely be fixed by #18261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/challenging 🤯 Categorizes an issue for which the difficulty level is reachable with internals understanding kind/bug Something isn't working platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform project/layout 🧱 Categorizes an issue or PR as relevant to layouting and containers (Measure/Arrange, Collections,..)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@MartinZikmund @jeromelaban @Youssef1313 @ramezgerges