Ability to clone a new project

[BinyaminPekar]

@uenz: could you, please check and confirm that your SparkleShare-windows-nightly.msi can clone a new project? I was not able to clone my SparkleShare fork on GitHub. However I must admit that it could be due to me messing around with the old and new installation and the Windows' AppData folder... Thank you for the great PR!

[uenz]

I´m sure that cloning repos and pushing / pulling files work with a locally built version. I´m also sure that pushing and pulling works with the installer version. So i (re)check that also cloning works with the installer, maybe there is an issue in the installer packet.

[uenz]

Unfortunately i can only confirm that cloning a new repository doesn´t work. But meanwhile i know why. When there is a space in the path to SparkleShare.exe cloning a repository will fail.
I suppose you installed it in the default location c:\Program Files (x86)\SparkleShare ? If so please uninstall it and install it in a path without spaces (e.g c:\SparkleShare). You can select this in the Destination Folder Pane of the installer. Then you should have the full functionality.
Can you please check and confirm? After that i will fix the "space issue" and create an new ci release which can handle spaces in the path.

[BinyaminPekar]

You were absolutely correct. Installing directly into C:\ allowed me to clone. Thank you for your fork. Once you fix this issue - I'll probably start using it in production.

Have a nice day!

[AvtechScientific]

Anything new on this?

[uenz]

The windows version is fixed, but the ci build chain for os x has some errors. I first wanted to fix this before the next build. If it takes to much time, i remove os x from the ci. This week the fixed windows version will be ready.

[AvtechScientific]

Do you want me to take a look on the Linux build? Can you post here what is the error message there?

[AvtechScientific]

Or even better link on the CI error message so I can see it myself in the real process...

[uenz]

There is no error, it builds just fine. But the script which should create the tar.gz does not work, because the files are not in the place the script searches it.

[AvtechScientific]

There is no error, it builds just fine. But the script which should create the tar.gz does not work, because the files are not in the place the script searches it.

So maybe we can either change the script to look in the place where the build artifacts currently are, or place the artifacts in the directory where the script expects them...

Can you, please, point on the script and the artifacts location?

[uenz]

If you want to take a look, its easiest to do the linux steps in travis.yaml on a local pc. The CI logfiles arent really helpfull and debugging with the CI is extremely time consuming. I switched to do all the debugging of the process locally and then try the locally working commands on the CI.
I think there is no need to use docker in the CI, but this is the "original" setup. At the moment i work on this branch.
I think the .yaml is the best documentation of the build steps and file location.

[uenz]

Hi, just ceated a new release, which works fine for me. If someone tries it, please give feedback here.
There is still an issue in the mac build process, therefore i only build a windows version.

[AvtechScientific]

@uenz - thank you very much! May I ask you to also merge this recent small translation PR, please, so I can test both (and so there is less merge work for @hbons at the end).

Thank you again!

[AvtechScientific]

Also, please, post the link to the .msi file to test...

[uenz]

Here is the Link to the latest setup file. The last merges which @hbons accepted were only small changes on one file. So changes to get it in the original sources are higher as single request.
But i can integrate it here also.
I have no idea how i can grab just the file...

[AvtechScientific]

I think you just checkout feature/WindowsTravisCi branch and then just git pull https://github.com/BinyaminPekar/SparkleShare.git or am I wrong?

[uenz]

@AvtechScientific Thanks for the git lesson, it worked! The next build will be with the updated language file.

[AvtechScientific]

Great, let me know, once you have it and don't forget to post the link on the .msi file. Thank you!

[AvtechScientific]

@uenz - any news on the new windows build (with the updated language file)?

[uenz]

Unfortunately i found another bug related to spaces in pathes, which i cant solve at the moment.
But the impact is small: the windows user folder must not contain spaces
Here is an new installer for further testing.
See the known bugs in above link.

[AvtechScientific]

No hurry... fix the bugs, once you have time... then let me know and I'll test it. Thank you!

[AvtechScientific]

@uenz - what do you mean by "is not possible to use encrypted repos"? You can't use SSH keys to access repos or something else?

[uenz]

No, ssh connections and key handling work fine.
When clonig a new bare repo SparkleShare asks if you want to encrypt the files on the server. See here under client side encryption. That this works the command openssl.exe is needed. This is not the "normal" usecase. I found a solution that the encryption also works, but i'll do a bit more testing before next build.

[uenz]

Im happy to announce the ReleaseCandidate 1 of the windows version here.
The updated language pack is included. All knows bugs are fixed. Only restriction is that the user folder name must not contain spaces.
Please test and give feedback. If no other bugs occure, ill merge the changes back to my pull request @hbons.

[AvtechScientific]

@uenz - thank you very much for the update!

I have tested the RC1 version you have provided and it worked really well:

1. It fixes the old unicode issue On windows, unicode file names are broken in Git log hbons/SparkleShare#1753
2. There are no problems with cloning repositories, even if SparkleShare is installed into a directory containing spaces in its name.

There is one thing that I've noticed which is different from the current official Windows version, however I can't call it a bug: once you clone a new project - then inside SparkleShare a new directory is created with the domain name of the host (in my case it was github.com), and the clone is put inside that directory. In the current version the clone was placed directly into the SparkleShare directory... Is this the expected behavior?

[uenz]

@AvtechScientific I also installed the version from the GitHub repo, but my repos are in a subfolder wich is named like the server. So I can’t confirm that behaviour and it is definitively not intended.

[AvtechScientific]

@uenz - try to clone some arbitrary repo from GitHub (and maybe GitLab - I didn't check it though) to see whether you observe this behavior...

[uenz]

@AvtechScientific When i clone a repo it resides where i expect it. Tried it with Github: \SparkleShare\github.com\tartool
Did you click on the Github Server Icon and then added the remote path or did you type all?
The pathname will be created in DetermineFolderPath in the file BaseController.cs. It will be generated from the RemoteURL. So if clonig works, the RemoteURL should be ok and resolve to a server / reponame structure.

[AvtechScientific]

I didn't click the "Github Server" icon during cloning but rather "My own server", however nevertheless I did clone my fork of SparkleShare from GitHub and it landed at: \SparkleShare\github.com\SparkleShare.
Ok, so it looks like it is intended behavior... I think the current version would clone it to \SparkleShare\SparkleShare, but it doesn't really matter...

[uenz]

@AvtechScientific If you mean the Version 1.4 as the current versiont, then you are rigth. The sparkleshare teams made this changes on the way to 2.x releases.

[AvtechScientific]

Yes, that's what I meant... If so - everything is great and you can merge! Thank you very much. I hope @hbons will merge it upstream as well soon...

[uenz]

This RC1 build solves all mentioned issues.